Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Link: Remove unit test code for < WP 6.5 #69069

Closed
wants to merge 1 commit into from

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Feb 6, 2025

What?

#58389 now uses get_block_type_variations to build variations for the Navigation Link block. This hook was first introduced in core version 6.5. Therefore, there was a backwards compatibility code to pass unit tests on core versions lower than 6.5.
However, this backwards compatibility code is no longer needed because Gutenberg currently supports core versions 6.6 and above.

Testing Instructions

The unit tests should pass.

@t-hamano t-hamano added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality labels Feb 6, 2025
@t-hamano t-hamano self-assigned this Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: Gutenberg Plugin, [Type] Code Quality.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@t-hamano t-hamano force-pushed the quality/navigation-link-test-compat branch from 79f08ea to 2be607e Compare February 7, 2025 02:03
@t-hamano t-hamano force-pushed the quality/navigation-link-test-compat branch from b52447d to 1fa5a2a Compare February 7, 2025 02:11
@t-hamano t-hamano closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant