Exclude Iterator helpers from polyfills #69070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
gziolo,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
the
No Core Sync Required
Mamaduka
force-pushed
the
update/exclude-set-instance-method-polyfills
branch
from
a6427a2 to
f4be902
Compare
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f4be902. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13174632003
|
Mamaduka
commented
Feb 6, 2025
phpunit/script-dependencies-test.php
Outdated
| 'wp-router', | ||
| 'wp-url', | ||
| 'wp-widgets', | ||
| 'wp-upload-media', |
There was a problem hiding this comment.
The wp-upload-media is missing from tests on CI, though it passes locally for me. Investigating.
swissspidy
reviewed
Feb 6, 2025
swissspidy
approved these changes
Feb 6, 2025
Mamaduka
force-pushed
the
update/exclude-set-instance-method-polyfills
branch
from
49a0855 to
d8b4834
Compare
Mamaduka
commented
Feb 6, 2025
Comment on lines
+20
to
+23
| // Ignore bundled packages, they don't load separate polyfills. | ||
| if ( in_array( $registered_handle, $this->bundled_scripts, true ) ) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
It is not ideal, but I couldn't find out why wp-upload-media is missing from $dependents on CI. However, we could skip checking for bundled packages as they are not enqueued separately.
The unit tests are passing without an issue locally. Happy to adjust further if anyone has ideas why this is only failing on CI.
Mamaduka
force-pushed
the
update/exclude-set-instance-method-polyfills
branch
from
a59d072 to
75f8e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #67230.
Related WordPress/wordpress-develop#8224.
PR updates the polyfill exclusion list and adds a rule for new
Iteratorhelpers.Why?
When
core-jswas updated in #67708, it accidentally re-introducedwp-polyfillas a dependency for multiple packages.Testing Instructions
CI tests are passing.