RM-27055 added Queue methods: GetItems, GetItem, Search, Clear #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
nikepan
changed the title
|
+1 |
1 similar comment
|
+1 |
|
You'll need to pull in master to get the build to pass @nikepan |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
|
Updated |
rmconsole-wf
changed the title
|
+1 |
tonylambiris
pushed a commit
to tonylambiris/go-datastructures
that referenced
this pull request
Apr 14, 2018
tonylambiris
pushed a commit
to tonylambiris/go-datastructures
that referenced
this pull request
Jul 26, 2018
|
+1 |
|
|
||
| returnItems := make([]interface{}, 0, length) | ||
| for _, item := range *items { | ||
| if !checker(item) { |
There was a problem hiding this comment.
to me it seems unintuitive that this would return objects that do not pass checker, I'd expect the opposite behavior
| return nil, false | ||
| } | ||
|
|
||
| // GetItems returns items in this queue. |
There was a problem hiding this comment.
Comment doesn't seem to define the exact behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional methods for working with queue.
Thats useful, when you need interact with queue items (send stop signal and clear queue)