Draft MR for reviews #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update message "already loaded" in SYNFHIR to contain filename. - Update `SYNINIT` to suppress "Late ACRP Related Bulletins".
- There was a lot of code that syncs data between systems; or points
to dead termininology servers. All such code while potentially useful
can open us to security issues in case the domains are taken over.
- SYNFPUL, SYNFVF, SYNSYNCH entire routines removed.
- Code in SYNF{ALG,APT,MED2} that pointed to SYNFPUL has now been
removed.
- SYNDHPMP did a lot of terminlogy lookups on a now defunct server. We
don't support remote server terminology lookups, and all that code has
now been removed. The defunct servers used to be owned by a previous
sponsor of the project.
- Here's a list of the remaining URLs in code (not in comments) in the project:
- SYNFPAT: `set ssnref="http://hl7.org/fhir/sid/us-ssn"`. Used as
a varaible, never used in a URL.
- SYNFMED: `N URL S
URL="https://rxnav.nlm.nih.gov/REST/rxcui/{RXN}/property.json?propName=VUID"`.
Well known API for RxNorm API. A future version of the project
may use this.
- All SYNJSON* routines now removed. - References to SYNJSON were examined and either changed to XLFJSON; or if found to be only of use to the earlier web-server version of the code, they were just removed. Most actually fall in the latter category. After these changes, 120 patients were loaded for testing and everything looks good.
…. add Lab Panels to status display
shabiel
commented
Jan 27, 2025
|
I committed all the changes that are discussed above. I'll leave it to you to resolve them once you check. |
SYNFHIR: - Suppress talking from Fileman by setting DIQUIET (happens when filing Encounters and Procedures) - Cosmetic write fixes SYNINIT: - Main menu is SYNMENU, not XUCORE
|
these changes have been committed |
shabiel
commented
Jan 28, 2025
shabiel
commented
Jan 28, 2025
| . ; lab panel | ||
| . ; | ||
| . N PANEL | ||
| . S PANEL=$$MAP^SYNQLDM(loinc,"vistapanel") |
There was a problem hiding this comment.
I figured out why you don't show failed panels. You need to add a line here if a panel is not found.
shabiel
commented
Jan 28, 2025
Result was that panels didn't file, and labs filed instead.
|
thank you
…On Tue, Jan 28, 2025 at 11:00 AM Sam Habiel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/SYNFPAN.m
<#48 (comment)>
:
> + ;
+ new obscode set ***@***.***@("entry",ien,"resource","code","coding",1,"code"))
+ do log(lablog,"result "_zj_" code is: "_obscode)
+ do log(jlog,"result "_zj_" code is: "_obscode)
+ set @eval@("labs",SYNZI,"vars",zj_" code")=obscode
+ ;
+ ;
+ new codesystem set ***@***.***@("entry",ien,"resource","code","coding",1,"system"))
+ do log(jlog,"result "_zj_" code system is: "_codesystem)
+ do log(lablog,"result "_zj_" code system is: "_codesystem)
+ set @eval@("labs",SYNZI,"vars",zj_" codeSystem")=codesystem
+ ;
+ ; determine the value and units
+ ;
+ new value set ***@***.***@("entry",ien,"resource","valueQuantity","value"))
+ if value="" d ;
That caused a real issue, and I found it and fixed it.
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJNJX7WV5YPGDYJ4GF6ZYL2M6STDAVCNFSM6AAAAABV6OCTJGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZYG4ZDSNBXGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
- Initilize counters and don't use $get (to make sure we get zeros if nothing got imported) - Fix adjustment to values so that it works correctly (initial code didn't)
- Make new users for Synthea not login users by removing setting of Verify codes (Access Codes still needed in order to ensure Mailman and other parts of VistA still function). - Remove new users for Synthea from Intro message - Check for XUMGR before KIDS starts installation in ENV and Pre-install. - Since we now don't expect to use our new users as login users, check for LRLAB and LRVERIFY keys before starting patient loads. If these are not present, don't start load. - Rollover lab accession numbers by default. It's a no-op if it is not needed. This suppresses error messages from the lab package in case rollover is not done on a nightly basis in Taskman. - Add a way (now the default) to import only one patient at a time. Importing multiple patients, while useful for a batch operation, results in our inability to terminate the import early. You can still import multiple patients if you want. - Code cleanup in SYNKIDS - Move ^SYNINIT to be under POST - Reorganize tags to be in the order they are called - Removed unused tags
SYNFHIR: - Remember previous directory - Pick next unloaded patient by default SYNFLAB: - Code that grabbed values was using wrong variable - If value cannot be found, log and count as error - Move GFR sksip earlier (it stopped working since the test isn't mapped, and that check now happens as of a few commits ago) and add its count to "loaded" - Fix error counts for labs that are not found SYNFPAN: - Add 24356-8 as URINALYSIS - Remove unused loinc2sct label SYNKIDS - Remove XUMGR check in PRE SYNQLDM - Add HCT mapping - Fix Troponin LOINC (previous was for panel, not atomic test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.