Refactoring to avoid double md5($uniqueid)

Wunderbyte-GmbH · Nov 29, 2023 · 8ff46cc · 8ff46cc
1 parent 070c8fc
commit 8ff46cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/classes/output/demo.php b/classes/output/demo.php
@@ -31,7 +31,6 @@
 use renderer_base;
 use templatable;
 
-
 define('TABLE1NAME', get_string('table1name', 'local_wunderbyte_table'));
 define('TABLE2NAME', get_string('table2name', 'local_wunderbyte_table'));
 define('TABLE3NAME', get_string('table3name', 'local_wunderbyte_table'));

diff --git a/classes/wunderbyte_table.php b/classes/wunderbyte_table.php
@@ -299,10 +299,9 @@ class wunderbyte_table extends table_sql {
      */
     public function __construct($uniqueid) {
 
-        $uniqueid = md5($uniqueid); // Must to avoid unwanted symbols especially spaces, etc.
-        parent::__construct($uniqueid);
-
         $this->idstring = md5($uniqueid);
+        parent::__construct($this->idstring);
+
         $this->classname = get_class($this);
 
         // This unsets the eventual memory of sorting in session to apply the default sorting on load as defined.