Improve the layout of the promotion screen (#13) #45
Conversation
This commit shortens the promotion screen and adjusts the camera a bit so everything fits better, particularly when used with a Brigadier rank. Fixes include: - The visible tearing with Brigadier rank is gone - SPARKs no longer hide the Brigadier rank Fixes #13.
|
Hmmm...the scrollbar is currently missing in action. Not sure why. May need to get kdm2k6 to help. |
|
It only appears when there's somewhere to scroll, so dumb question - are you on a soldier with more than 4 rows? |
|
Yes, there's supposed to be scrollbar (our row of pistol abilities are always below the "fold"). I've tracked down the issue. There was an important change that wasn't in the original pull request. It must have been made in an earlier commit. |
|
I see. So I should wait for you to update this before I test things out? |
|
The scrollbar is still broken in windowed mode: https://i.imgur.com/TIpRGqq.jpg But that can be fixed separately. The box in the lower left corner bothers the hell out of my peripheral vision, but I suppose it's a matter of habit. The new layout seems better overall, so yeah, merging. |
|
Correction: the scrollbar is broken in fullscreen mode as well, appears to be offset to the left by the same amount. This needs to be fixed before this can be merged. |
(This was originally a LWOTC pull request)
This commit shortens the promotion screen and adjusts the camera a bit so everything fits better, particularly when used with a Brigadier rank.
Fixes include:
Fixes #13.