Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config gate creation of auto-generated photos (#1453) #1454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BlackDog86
Copy link
Contributor

Fixes Issue #1453 - Preliminary tests are convincing.

Further testing ongoing - will comment again once completed and confident the fix covers all possible scenarios (In particular, need to test soldier captured events, as I didn't adjust anything related to that, assuming that the auto-gen code used for captures is mainly there for creating the poster in the UI alert which is displayed when a capture occurs and not for actually saving the photo to the campaign photobooth folder).

@BlackDog86 BlackDog86 force-pushed the 1453-Disable-AutoPhotoBooth branch 2 times, most recently from 3d99aae to 2e75e8e Compare January 14, 2025 22:48
@BlackDog86 BlackDog86 self-assigned this Jan 14, 2025
@BlackDog86 BlackDog86 added this to the 1.30.0 milestone Jan 14, 2025
@BlackDog86 BlackDog86 force-pushed the 1453-Disable-AutoPhotoBooth branch 3 times, most recently from 1b03478 to 940934d Compare January 16, 2025 06:38
@BlackDog86 BlackDog86 requested a review from Iridar January 16, 2025 06:38
@BlackDog86 BlackDog86 force-pushed the 1453-Disable-AutoPhotoBooth branch from 940934d to 2a483c0 Compare January 16, 2025 06:45
@BlackDog86 BlackDog86 force-pushed the 1453-Disable-AutoPhotoBooth branch from 2a483c0 to 1d00e37 Compare January 16, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant