Add support for choice from previous repeat answers #381
Conversation
ukanga
force-pushed
the
choice-from-previous-repeat-answers
branch
from
c8041a0 to
21cf594
Compare
| if depth > 2: | ||
| name = path[-1] | ||
| nodeset = "/".join( | ||
| path[:-2] + [path[-2] + "[string-length(./" + name + ") > 0]"] |
There was a problem hiding this comment.
I think that string-length(./" + name + ") > 0 is not intended to be hardcoded. It should just be whatever the contents of the choice_filter column is.
With the following definition:
| type | name | label | choice_filter |
|---|---|---|---|
| begin repeat | rep | ||
| text | food | Enter food | |
| end repeat | |||
| select_one ${food} | choice | Choose |
There should be no predicate at all.
With the following definition:
| type | name | label | choice_filter |
|---|---|---|---|
| begin repeat | rep | ||
| text | food | Enter food | |
| end repeat | |||
| select_one ${food} | choice | Choose | starts-with(., "b") |
The predicate should be starts-with(., "b").
Note that the choice filter/predicate could possibly include a reference to another node (starts-with(., ${favorite_letter}).
| nodeset = "/".join( | ||
| path[:-2] + [path[-2] + "[string-length(./" + name + ") > 0]"] | ||
| ) | ||
| itemset_children = [node("value", ref=name), node("label", ref=name)] |
There was a problem hiding this comment.
This is related to #370 because the values will be user-generated and could contain spaces. If this turns out to be a popular feature, we may want to allow users to specify value and label separately. I don't think this needs to be done now but wanted to call it out in case that changes things for anyone.
| self.assertPyxformXform( | ||
| md=xlsform_md, | ||
| xml__contains=[ | ||
| '<itemset nodeset="/pyxform_autotestname/rep[string-length(./name) > 0]">' |
There was a problem hiding this comment.
There shouldn't be a predicate.
|
Superseded by #472 |
Fix #38