evm: fixes access control admin removal

XLabs · Dec 16, 2024 · 788abc6 · 788abc6
1 parent 00b697a
commit 788abc6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/evm/src/assets/sharedComponents/AccessControl.sol b/evm/src/assets/sharedComponents/AccessControl.sol
@@ -235,8 +235,12 @@ abstract contract AccessControl {
     }
     else {
       uint256 rawIndex = state.isAdmin[admin];
-      if (rawIndex != state.admins.length)
-        state.admins[rawIndex - 1] = state.admins[state.admins.length - 1];
+      if (rawIndex != state.admins.length) {
+        address tmpAdmin = state.admins[state.admins.length - 1];
+        uint256 newIndex = rawIndex - 1;
+        state.isAdmin[tmpAdmin] = newIndex;
+        state.admins[newIndex] = tmpAdmin;
+      }
 
       state.isAdmin[admin] = 0;
       state.admins.pop();