Bugs/fix undefined (#938)

* fix undefined from PUBLIC_URL * update env var reference
XLabs · Jul 19, 2024 · f061612 · f061612
1 parent 0a76a11
commit f061612
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -221,6 +221,7 @@ jobs:
       - name: Build Custom Wormhole Connect Loader
         env:
           PUBLIC_URL: ${{ inputs.public-url }}
+          VITE_PUBLIC_URL: ${{ inputs.public-url }}
           VITE_APP_VERSION: ${{ steps.set-version.outputs._PKG_VERSION }}
           VITE_APP_CLUSTER: ${{ vars.REACT_APP_CLUSTER }}
           # VITE_APP_JS_WC_INTEGRITY_SHA_384: ${{ steps.wormhole-connect.outputs._JS_SHA_384 }}
@@ -285,6 +286,7 @@ jobs:
       - name: Build Custom Wormhole Connect Loader
         env:
           PUBLIC_URL: "${{ inputs.public-url }}"
+          VITE_PUBLIC_URL: ${{ inputs.public-url }}
           VITE_APP_VERSION: ${{ steps.set-version.outputs._PKG_VERSION }}
           VITE_APP_CLUSTER: ${{ vars.REACT_APP_CLUSTER }}
           # VITE_APP_JS_WC_INTEGRITY_SHA_384: ${{ steps.wormhole-connect.outputs._JS_SHA_384 }}

diff --git a/apps/connect/src/env/common.ts b/apps/connect/src/env/common.ts
@@ -35,7 +35,7 @@ export const MAINNET_RPCS = {
   solana: "https://wormhole.rpcpool.com/",
 };
 
-export const PUBLIC_URL = envVars.PUBLIC_URL || "";
+export const PUBLIC_URL = envVars.VITE_PUBLIC_URL || "";
 
 export const versions: Env["versions"] = [
   {
@@ -60,12 +60,12 @@ export const wormholeConnectConfigCommon: Partial<WormholeConnectConfig> = {
   menu: [
     {
       label: "Advanced Tools",
-      href: `${envVars.PUBLIC_URL}/advanced-tools/`,
+      href: `${PUBLIC_URL}/advanced-tools/`,
       order: 1,
     },
     {
       label: "Privacy Policy",
-      href: `${envVars.PUBLIC_URL}/#/privacy-policy/`,
+      href: `${PUBLIC_URL}/#/privacy-policy/`,
     },
   ],
 };