-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump black, bump flake8, remove unused dev-dependencies #742
Changes from 6 commits
b0ea3a1
c5156d1
d912d6d
487b5da
a66707d
0e43f75
8ba6c03
0b11443
45479e3
27e7972
3c647b6
563897f
0a6794b
43fc875
02fc14a
5cf0624
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ include = ["LICENSE"] | |
packages = [{ include = "xrpl" }] | ||
|
||
[tool.poetry.dependencies] | ||
python = "^3.8" | ||
python = ">=3.8.1,<3.14" | ||
base58 = "^2.1.0" | ||
ECPy = "^1.2.5" | ||
typing-extensions = "^4.2.0" | ||
|
@@ -34,14 +34,13 @@ types-Deprecated = "^1.2.9" | |
pycryptodome = "^3.16.0" | ||
|
||
[tool.poetry.dev-dependencies] | ||
flake8 = "^4.0.1" | ||
black = "23.3.0" | ||
flake8 = "^7.0.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PR title should be updated with this as well |
||
black = "24.8.0" | ||
flake8-black = "^0.3.6" | ||
flake8-docstrings = "^1.7.0" | ||
mypy = "^1" | ||
isort = "^5.11.5" | ||
flake8-isort = "^6.0.0" | ||
flake8-annotations = "2.7.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have updated the rationale for the removal in the description of the PR. But I couldn't find any usages of this dependency. Where is it used? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It isn't used directly, it's used by flake8 to check function annotations: https://github.com/sco1/flake8-annotations?tab=readme-ov-file#table-of-warnings There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks. updated in 563897f |
||
flake8-absolute-import = "^1.0" | ||
darglint = "^1.5.8" | ||
sphinx-rtd-theme = "^3.0.0" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
"""High-level XRPL exports for async support.""" | ||
|
||
from xrpl.asyncio import account, clients, ledger, transaction, wallet | ||
|
||
__all__ = ["account", "clients", "ledger", "transaction", "wallet"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
"""Collection of public constants for XRPL.""" | ||
|
||
import re | ||
from decimal import Context | ||
from enum import Enum | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
"""Core codec functions for interacting with the XRPL.""" | ||
|
||
from xrpl.core import addresscodec, binarycodec, keypairs | ||
|
||
__all__ = ["addresscodec", "binarycodec", "keypairs"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
"""General XRPL Address Codec Exceptions.""" | ||
|
||
from xrpl.constants import XRPLException | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
"""This module contains commonly-used constants.""" | ||
|
||
from typing_extensions import Final | ||
|
||
# The dictionary used for XRPL base58 encodings | ||
XRPL_ALPHABET: Final[ | ||
bytes | ||
] = b"rpshnaf39wBUDNEGHJKLM4PQRST7VWXYZ2bcdeCg65jkm8oFqi1tuvAxyz" | ||
XRPL_ALPHABET: Final[bytes] = ( | ||
b"rpshnaf39wBUDNEGHJKLM4PQRST7VWXYZ2bcdeCg65jkm8oFqi1tuvAxyz" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a max number here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the dependencies
darglint
has an upper bound on the supported Python version. Here is the error message:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the complete error log:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a PR replacing darglint, so this is probably a moot point: #749
It's a very outdated package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can include
<4.0
, but it shouldn't be gating minor releases. Most of them work automatically (see #753), so gating it would actually be worse/require more work, since this would prevent it from working automatically without a version bump.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 43fc875
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't yet looked at the darglint PR. We could revisit the gating upper bound later.