clearer naming

XYOracleNetwork · Sep 6, 2024 · 9b68a95 · 9b68a95
1 parent b9cda22
commit 9b68a95
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 17 deletions.
diff --git a/packages/sdk/packages/xns/src/components/XnsNameCapture/Props.ts b/packages/sdk/packages/xns/src/components/XnsNameCapture/Props.ts
@@ -5,7 +5,7 @@ import type { ReactNode } from 'react'
 import type { To } from 'react-router-dom'
 
 export interface XnsNameCaptureBuyCallbacks {
-  onBuyName?: (name: string) => Promise<void>
+  onCaptureName?: (name: string) => Promise<void>
 }
 
 /**

diff --git a/packages/sdk/packages/xns/src/components/XnsNameCapture/SecondaryLink.stories.tsx b/packages/sdk/packages/xns/src/components/XnsNameCapture/SecondaryLink.stories.tsx
@@ -13,6 +13,6 @@ const Default = Template.bind({})
 Default.args = {}
 
 const WithOnBuyName = Template.bind({})
-WithOnBuyName.args = { xnsName: 'testing123', onBuyName: (name: string) => Promise.resolve(alert(`Buy Name: ${name}`)) }
+WithOnBuyName.args = { xnsName: 'testing123', onCaptureName: (name: string) => Promise.resolve(alert(`Buy Name: ${name}`)) }
 
 export { Default, WithOnBuyName }
diff --git a/packages/sdk/packages/xns/src/components/XnsNameCapture/SecondaryLink.tsx b/packages/sdk/packages/xns/src/components/XnsNameCapture/SecondaryLink.tsx
@@ -24,7 +24,7 @@ export const XnsCaptureSecondaryLink: React.FC<XnsCaptureSecondaryLinkProps> = (
   funnel = 'xns',
   mixpanel,
   navigate,
-  onBuyName,
+  onCaptureName,
   paramsString = '',
   placement = '',
   setError,
@@ -50,7 +50,7 @@ export const XnsCaptureSecondaryLink: React.FC<XnsCaptureSecondaryLinkProps> = (
         if (valid) {
           await userEvents?.userClick({ elementName: event, elementType: 'xns-cta' })
           navigate?.(`${to}?username=${xnsName}${paramsString}`)
-          await onBuyName?.(xnsName)
+          await onCaptureName?.(xnsName)
         } else {
           setError?.(new Error(errors.join(', ')))
         }

diff --git a/packages/sdk/packages/xns/src/components/XnsNameCapture/XnsNameCapture.stories.tsx b/packages/sdk/packages/xns/src/components/XnsNameCapture/XnsNameCapture.stories.tsx
@@ -14,6 +14,6 @@ const Default = Template.bind({})
 Default.args = {}
 
 const WithOnBuyName = Template.bind({})
-WithOnBuyName.args = { navigate: (to: To) => alert(`navigated to: ${to}`), onBuyName: (name: string) => Promise.resolve(alert(`Buy Name: ${name}`)) }
+WithOnBuyName.args = { navigate: (to: To) => alert(`navigated to: ${to}`), onCaptureName: (name: string) => Promise.resolve(alert(`Buy Name: ${name}`)) }
 
 export { Default, WithOnBuyName }
diff --git a/packages/sdk/packages/xns/src/components/XnsNameCapture/XnsNameCapture.tsx b/packages/sdk/packages/xns/src/components/XnsNameCapture/XnsNameCapture.tsx
@@ -23,7 +23,7 @@ export const XnsNameCapture: React.FC<XnsNameCaptureProps> = ({
   mixpanel,
   mobileButtonText = 'Buy',
   navigate,
-  onBuyName: onBuyNameProp,
+  onCaptureName: onCaptureNameProp,
   paramsString = '',
   placement = '',
   showSecondary = false,
@@ -37,17 +37,16 @@ export const XnsNameCapture: React.FC<XnsNameCaptureProps> = ({
   const theme = useTheme()
   const isMobile = useMediaQuery(theme.breakpoints.down('md'))
 
-  const buyDisabled = !xnsName || xnsName.length < MIN_DOMAIN_LENGTH
+  const captureDisabled = !xnsName || xnsName.length < MIN_DOMAIN_LENGTH
 
   const handleChange: StandardTextFieldProps['onChange'] = (event) => {
     const NsName = XnsNameHelper.mask(event.target.value)
     setXnsName(NsName)
     setError(undefined)
   }
 
-  const onBuyName = useCallback(async () => {
-    if (!xnsName) return
-
+  const onCaptureName = useCallback(async () => {
+    if (captureDisabled) return
     mixpanel?.track(event, {
       Funnel: funnel,
       Placement: placement,
@@ -57,18 +56,18 @@ export const XnsNameCapture: React.FC<XnsNameCaptureProps> = ({
     const [valid, errors] = await helper.validate()
     if (valid) {
       await userEvents?.userClick({ elementName: event, elementType: 'xns-cta' })
-      await onBuyNameProp?.(xnsName)
+      await onCaptureNameProp?.(xnsName)
       navigate?.(`${to}?username=${xnsName}${paramsString}`)
     } else {
       setError(new Error(errors.join(', ')))
     }
   }, [event, funnel, mixpanel, paramsString, placement, to, userEvents, xnsName])
 
   const onKeyDown: KeyboardEventHandler<HTMLDivElement> = useCallback(async (event) => {
-    if (event.key === 'Enter' && !buyDisabled) {
-      await onBuyName?.()
+    if (event.key === 'Enter' && !captureDisabled) {
+      await onCaptureName?.()
     }
-  }, [buyDisabled, onBuyName])
+  }, [captureDisabled, onCaptureName])
 
   return (
     <FlexCol gap={showSecondary ? 1.5 : 0} alignItems="center" {...props}>
@@ -84,11 +83,11 @@ export const XnsNameCapture: React.FC<XnsNameCaptureProps> = ({
           onBlur={handleChange}
         />
         <ButtonEx
-          disabled={buyDisabled}
+          disabled={captureDisabled}
           variant="contained"
           color="success"
           endIcon={<KeyboardArrowRightRounded />}
-          onClick={onBuyName}
+          onClick={onCaptureName}
         >
           {isMobile ? mobileButtonText : buttonText}
         </ButtonEx>

diff --git a/...ages/sdk/packages/xns/src/components/XnsNameCapture/XnsNameCaptureWithContext.stories.tsx b/...ages/sdk/packages/xns/src/components/XnsNameCapture/XnsNameCaptureWithContext.stories.tsx
@@ -27,6 +27,6 @@ const Default = Template.bind({})
 Default.args = {}
 
 const WithOnBuyName = Template.bind({})
-WithOnBuyName.args = { navigate: (to: To) => alert(`navigated to: ${to}`), onBuyName: (name: string) => Promise.resolve(alert(`Buy Name: ${name}`)) }
+WithOnBuyName.args = { navigate: (to: To) => alert(`navigated to: ${to}`), onCaptureName: (name: string) => Promise.resolve(alert(`Buy Name: ${name}`)) }
 
 export { Default, WithOnBuyName }