Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making S2gate of lab and lab_dev the same #548

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

arsalan-motamedi
Copy link
Collaborator

Context:
there is a discrepancy between lab and lab_dev in defining S2gate : squeezing parameter of one is the negative of the other.

Description of the Change:
Making S2gate of lab and lab_dev compatible by changing the lab_dev one.

Benefits:
Consistency.

Possible Drawbacks:
None

Related GitHub Issues:
None

@arsalan-motamedi arsalan-motamedi added the no changelog Pull request does not require a CHANGELOG entry label Jan 31, 2025
@arsalan-motamedi arsalan-motamedi changed the title Making S2gate of lab and lab_dev Making S2gate of lab and lab_dev the same Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (5a11703) to head (701051b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #548   +/-   ##
========================================
  Coverage    90.05%   90.05%           
========================================
  Files          102      102           
  Lines         6222     6222           
========================================
  Hits          5603     5603           
  Misses         619      619           
Files with missing lines Coverage Δ
...mustard/lab_dev/states/two_mode_squeezed_vacuum.py 100.00% <ø> (ø)
mrmustard/lab_dev/transformations/s2gate.py 100.00% <ø> (ø)
mrmustard/physics/triples.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a11703...701051b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant