Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HCN and HCOH #50

Merged
merged 17 commits into from
Dec 20, 2024
Merged

Update HCN and HCOH #50

merged 17 commits into from
Dec 20, 2024

Conversation

DSGuala
Copy link
Contributor

@DSGuala DSGuala commented Nov 27, 2024 •
edited
Loading

Additional requirements

These need to be completed after merging.

  • Delete HCN 1.156 from S3
  • Rename HCOH files and folders in S3 to CH2O
  • Update the foldermap to use CH2O instead of HCOH

Shortcut tickets

SC-43934
SC-48779

@shortcut-integration Shortcut Integration
Copy link

shortcut-integration bot commented Nov 27, 2024 •
edited by DSGuala
Loading

This pull request has been linked to:

@DSGuala DSGuala changed the title Content improvements Update HCN and HCOH Dec 17, 2024
@DSGuala DSGuala marked this pull request as ready for review December 17, 2024 16:17
@DSGuala DSGuala requested a review from anthayes92 December 17, 2024 16:20
anthayes92
anthayes92 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@anthayes92 anthayes92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one change - the file name Dataset_ChemThumb_H2Co.png should be ..._H2CO.png.

Do we need to update any dateOfLastModification fields?

@DSGuala DSGuala merged commit 225bc2f into main Dec 20, 2024
2 checks passed
@DSGuala DSGuala deleted the content_improvements branch December 20, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthayes92 anthayes92 anthayes92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DSGuala @anthayes92