Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC80249 | Add Username Attribute To Authors #55

Merged

Conversation

AndrewGardhouse
Copy link
Contributor

@AndrewGardhouse AndrewGardhouse commented Dec 12, 2024

Story

https://app.shortcut.com/xanaduai/story/80249/add-username-attribute-to-authors-in-pennylane-datasets-repo

Changes

  • Combine AuthorHandle and AuthorName models into single Author model with name and username attributes
  • Add username attribute to meta.json files for Diego Guala, Maria Schuld, and Utkarsh Azad

Copy link
Contributor

@brownj85 brownj85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! To be safe let's hold off on merging until backend PR is merged

@brownj85 brownj85 added the ⚠️ Do Not Merge ⚠️ Do not merge this PR. label Dec 16, 2024
@AndrewGardhouse AndrewGardhouse removed the ⚠️ Do Not Merge ⚠️ Do not merge this PR. label Dec 17, 2024
@AndrewGardhouse AndrewGardhouse merged commit 1ccf8fa into main Dec 18, 2024
4 checks passed
@AndrewGardhouse AndrewGardhouse deleted the sc-80249-add-username-attribute-to-authors-in-pennylane branch December 18, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants