Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependency Tree #359

Merged
merged 3 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions config/neodymium.properties
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ neodymium.lighthouse.assert.thresholdScore.bestPractices = 0.5
neodymium.lighthouse.assert.thresholdScore.seo = 0.5

# To be able to validate Lighthouse report audits, we use internal json id's from the report itself
# A full list of all audit id's and their corresponding titles can be found here: https://github.com/Xceptance/neodymium/wiki/Reports#lighthouse-audit-validation
# A full list of all audit id's and their corresponding titles can be found here: https://github.com/Xceptance/neodymium/wiki/Accessibility#lighthouse-audit-validation
#neodymium.lighthouse.assert.audits =

#############################
Expand Down Expand Up @@ -416,4 +416,3 @@ neodymium.report.showSelenideErrorDetails = false
#
# The delay between two checks for a popup in milliseconds
#neodymium.popupInterval = 1000

24 changes: 23 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,22 @@
<artifactId>selenium-shutterbug</artifactId>
<version>1.6</version>
<exclusions>
<exclusion>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
</exclusion>
<exclusion>
<groupId>org.jsoup</groupId>
<artifactId>jsoup</artifactId>
</exclusion>
<exclusion>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId>
Expand All @@ -264,12 +280,12 @@
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>io.github.littleproxy</groupId>
<artifactId>littleproxy</artifactId>
<version>2.4.0</version>
</dependency>

<dependency>
<groupId>com.github.valfirst.browserup-proxy</groupId>
<artifactId>browserup-proxy-mitm</artifactId>
Expand Down Expand Up @@ -349,6 +365,12 @@
<groupId>com.jayway.jsonpath</groupId>
<artifactId>json-path</artifactId>
<version>2.9.0</version>
<exclusions>
<exclusion>
<groupId>net.minidev</groupId>
<artifactId>json-smart</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.codeborne</groupId>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/xceptance/neodymium/util/DataUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class DataUtils

private static final Map<Thread, Boolean> ALLURE_ALL_DATA_USED_FLAG = Collections.synchronizedMap(new WeakHashMap<>());

private final static Configuration JSONPATH_CONFIGURATION = Configuration.builder().jsonProvider(new GsonJsonProvider(GSON))
public final static Configuration JSONPATH_CONFIGURATION = Configuration.builder().jsonProvider(new GsonJsonProvider(GSON))
.mappingProvider(new GsonMappingProvider(GSON)).build();

static Boolean getAllureAllDataUsedFlag()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

import io.qameta.allure.Allure;

import static com.xceptance.neodymium.util.DataUtils.JSONPATH_CONFIGURATION;

/**
* Powered by <a href="https://developer.chrome.com/docs/lighthouse/overview?hl=de">Lighthouse</a> (Copyright Google)
* <p>
Expand Down Expand Up @@ -254,8 +256,7 @@ private static void validateAudits(File json, String reportName) throws Exceptio

try
{
int value = JsonPath.read(json, jsonPath);

long value = JsonPath.using(JSONPATH_CONFIGURATION).parse(json).read(jsonPath);
if (value > 0)
{
errorAudits.add(audit.trim());
Expand Down