360.add missing testdata to report #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wurzelkuchen
requested changes
Feb 20, 2025
|
|
||
| import io.qameta.allure.Allure; | ||
|
|
||
| public class TestData extends HashMap<String, String> |
There was a problem hiding this comment.
Importand class, needs javadoc :)
|
|
||
| import io.qameta.allure.Allure; | ||
|
|
||
| public class TestData extends HashMap<String, String> |
There was a problem hiding this comment.
serializable class, needs serialVersionUID, even tho we don't plan to serialize it, having warnings in the code should be avoided.
|
Please add Unit tests for the newly created TestData class. Feel free to just convert the DataUtils test to TestData tests, since we will get rid of the DataUtils methods anyway |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.