Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Browser's default search engine #479

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Added Browser's default search engine #479

wants to merge 31 commits into from
+110 −21

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Jan 16, 2025 •
edited
Loading

📝 Description

Added Browser's current default search engine selecting option as first search engine

📸 Screenshots / 📹 Videos

image
image

🔗 Related Issues

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Jan 16, 2025 •
edited
Loading

todo: firefox support, translation

issue:
image
Search with div width decreased in English, no more one liner :(
need help with this one

@itz-rj-here itz-rj-here added enhancement New feature or request work in progress The issue is on progress to fix labels Jan 16, 2025
@itz-rj-here
Copy link
Collaborator

itz-rj-here commented Jan 16, 2025 •
edited by prem-k-r
Loading

issue: image Search with div width decreased, need help with this one

@Thunder-Blaze Mayhe he can :)

@Thunder-Blaze
Copy link
Contributor

issue: image Search with div width decreased, need help with this one

@Thunder-Blaze Mayhe he can :)

I'll try fixing it 👍🏻

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Jan 16, 2025 •
edited
Loading

issue: image Search with div width decreased in English, no more one liner, need help with this one

this and in Czech
image
it goes to third line, and so whole screen UI move upward a bit :(

@prem-k-r
Copy link
Collaborator Author

issue: image Search with div width decreased in English, no more one liner, need help with this one

this and in Czech image it goes to third line, and so whole screen UI move upward a bit :(

Actually, after #474 merges, it will resolve lol
no changes needed

@prem-k-r prem-k-r removed the work in progress The issue is on progress to fix label Jan 16, 2025
@Thunder-Blaze
Copy link
Contributor

Can we ... If length is more than expected or should break the words like in todolist

@prem-k-r
Copy link
Collaborator Author

let's leave it for now, after Youtube moving out to search on, this is fine, for now

@Thunder-Blaze
Copy link
Contributor

let's leave it for now, after Youtube moving out to search on, this is fine, for now

ahh yes 👍🏻 , I hadn't read the 2nd msg

@prem-k-r prem-k-r requested a review from itz-rj-here January 16, 2025 20:02
itz-rj-here
itz-rj-here reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ig we should first let the search with and on pr get merged then i think we should work on this one.

@prem-k-r
Copy link
Collaborator Author

Ig we should first let the search with and on pr get merged then i think we should work on this one.

Yeah, btw this pr is on main branch.. for chrome branch we might have to do toggle thing :|

@prem-k-r
Update script.js
95d0251 
fallback
@prem-k-r
Update index.html
db6850c 
update wrt pr 474
@prem-k-r
Update script.js
01244a2 
Scroll the newly selected item into view
@prem-k-r
Copy link
Collaborator Author

Yeah, btw this pr is on main branch.. for chrome branch we might have to do toggle thing

Now we can argue in favour of single purpose policy.

  • Making changes to the browser new tab page only
  • and not the user's search experience.

We are respecting the user's selected settings.
Users can temporarily switch search engine themselves if needed.

@itz-rj-here
Copy link
Collaborator

Thats a great idea actual.

This was referenced Jan 18, 2025
Merged
Open
@prem-k-r prem-k-r marked this pull request as ready for review January 19, 2025 11:07
@prem-k-r
Copy link
Collaborator Author

@XengShi, your opinion on this?

@XengShi
Copy link
Owner

XengShi commented Jan 19, 2025

@XengShi, your opinion on this?

Yes this should work perfectly!

@prem-k-r prem-k-r mentioned this pull request Jan 21, 2025
Open
@itz-rj-here itz-rj-here added changes required PR requires updates based on review feedback under discussion This request/suggestion is still under discussion labels Feb 8, 2025
@itz-rj-here itz-rj-here added the work in progress The issue is on progress to fix label Feb 19, 2025
@prem-k-r prem-k-r removed work in progress The issue is on progress to fix changes required PR requires updates based on review feedback labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunder-Blaze Thunder-Blaze Thunder-Blaze left review comments

@itz-rj-here itz-rj-here itz-rj-here left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request under discussion This request/suggestion is still under discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prem-k-r @itz-rj-here @Thunder-Blaze @XengShi