Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PageNotFound page #538

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update PageNotFound page #538

wants to merge 7 commits into from

Conversation

prem-k-r
Copy link
Collaborator

📝 Description

Simpler page

📸 Screenshots / 📹 Videos

image

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@prem-k-r prem-k-r added the docs Changes related to documentation label Feb 16, 2025
prem-k-r and others added 5 commits February 16, 2025 14:06
@prem-k-r
Squashed commit of the following:
ea28bc4 
commit 2c1353b
Author: Prem Kumar <[email protected]>
Date:   Tue Feb 11 23:50:18 2025 +0530

    Update date format for `ja` and `ko` (XengShi#529)

    * Update date format for ja and ko

    Co-Authored-By: dempavof <[email protected]>

    * Update clock.js

    ---------

    Co-authored-by: dempavof <[email protected]>

commit d2b6d1c
Author: Prem Kumar <[email protected]>
Date:   Tue Feb 11 23:49:18 2025 +0530

    Seperated `Shortcuts` code, Removed Instagram and Added Discord (XengShi#523)

    * split shortcuts

    * Add discord, remove instagram

    * Changed Gmail icon to increase its size

    * *updated yt icon

    * removed unnecessary
@prem-k-r
Update PageNotFound.html
e5ece58
@prem-k-r
Update PageNotFound.html
b3a5cfd
@prem-k-r
Merge branch 'main' into error-404-page
ab2e797
@prem-k-r
Merge branch 'error-404-page' of https://github.com/prem-k-r/material…
2fa2f77 
…YouNewTab into error-404-page
@itz-rj-here
Copy link
Collaborator

image
@prem-k-r it's not working properly...

@prem-k-r
Copy link
Collaborator Author

Well, it won't show until the merge..

Check here https://prem-k-r.github.io/materialYouNewTab/docs/PageNotFound.html

@itz-rj-here
Copy link
Collaborator

Well, it won't show until the merge..

Check here prem-k-r.github.io/materialYouNewTab/docs/PageNotFound.html

Well. Ig you should add the user-select: none

@prem-k-r
Copy link
Collaborator Author

It will be better if we can stop altogether creation of shortcut if url is invalid..
Tried before.. couldn't make it through.. too many bugs

@prem-k-r
Copy link
Collaborator Author

Well, it won't show until the merge..
Check here prem-k-r.github.io/materialYouNewTab/docs/PageNotFound.html

Well. Ig you should add the user-select: none

Yeah maybe.. alongwith a hover text or something saying Url is invalid

@itz-rj-here
Copy link
Collaborator

It will be better if we can stop altogether creation of shortcut if url is invalid.. Tried before.. couldn't make it through.. too many bugs

I also tried. It returns an unusual error with the code. I guess if we used the Node package on the project, we could use it to fix it's issue.

@prem-k-r
Copy link
Collaborator Author

this webpage link is with users
we can delete this after an upate if we could do the disabling before the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Changes related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prem-k-r @itz-rj-here