Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: eddieh-xlnx <[email protected]>

Signed-off-by: Eddie Hung <[email protected]>
  • Loading branch information
eddieh-xlnx committed Jan 2, 2025
1 parent c76aa4d commit 2a96896
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions test/src/com/xilinx/rapidwright/design/TestDesignTools.java
Original file line number Diff line number Diff line change
Expand Up @@ -1476,12 +1476,8 @@ public void testGetConnectedCellsVersal() {
Assertions.assertEquals("[processor/zero_flag_flop(BEL: DFF2)]",
DesignTools.getConnectedCells(spi).stream().map(Cell::toString).sorted().collect(Collectors.toList()).toString());
}
// This design has no site routing for CLK
// {
// SitePinInst spi = si.getSitePinInst("CLK");
// Assertions.assertEquals("[]",
// DesignTools.getConnectedCells(spi).stream().map(Cell::toString).sorted().collect(Collectors.toList()).toString());
// }
// This design has no intra-site routing for CLK so this test
// does not check for connected cells as done in other tests
}

@Test
Expand All @@ -1508,12 +1504,8 @@ public void testGetConnectedBELPinsVersal() {
Assertions.assertEquals("[DFF2.CE]",
DesignTools.getConnectedBELPins(spi).stream().map(BELPin::toString).sorted().collect(Collectors.toList()).toString());
}
// This design has no site routing for CLK
// {
// SitePinInst spi = si.getSitePinInst("CLK");
// Assertions.assertEquals("[]",
// DesignTools.getConnectedBELPins(spi).stream().map(BELPin::toString).sorted().collect(Collectors.toList()).toString());
// }
// This design has no intra-site routing for CLK so this test
// does not check for connected cells as done in other tests
}

@ParameterizedTest
Expand Down

0 comments on commit 2a96896

Please sign in to comment.