ReportRouteStatusResult.isFullyRouted() to check >0 logical net found (…

…#852) * Test that invalid input to ReportRouteStatusResult for isFullyRouted() Signed-off-by: Eddie Hung <[email protected]> * ReportRouteStatusResult.isFullyRouted() to check at least one logical net found Signed-off-by: Eddie Hung <[email protected]> --------- Signed-off-by: Eddie Hung <[email protected]>
Xilinx · Oct 16, 2023 · b353074 · b353074
1 parent 398b79f
commit b353074
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/com/xilinx/rapidwright/util/ReportRouteStatusResult.java b/src/com/xilinx/rapidwright/util/ReportRouteStatusResult.java
@@ -72,7 +72,7 @@ public ReportRouteStatusResult(List<String> log) {
     }
 
     public boolean isFullyRouted() {
-        return unroutedNets == 0 && netsWithRoutingErrors == 0;
+        return logicalNets > 0 && unroutedNets == 0 && netsWithRoutingErrors == 0;
     }
 
 }
diff --git a/test/src/com/xilinx/rapidwright/util/TestVivadoTools.java b/test/src/com/xilinx/rapidwright/util/TestVivadoTools.java
@@ -34,6 +34,7 @@
 
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.Arrays;
 import java.util.List;
 
 public class TestVivadoTools {
@@ -79,6 +80,16 @@ private void assertVivadoLogContains(List<String> log, String query) {
         Assertions.assertTrue(0 < result.size());
     }
 
+    @Test
+    public void testReportRouteStatusInvalid() {
+        ReportRouteStatusResult rrs = new ReportRouteStatusResult(Arrays.asList(
+                "foo",
+                "bar",
+                "blah"
+        ));
+        Assertions.assertFalse(rrs.isFullyRouted());
+    }
+
     @Test
     public void testWriteBitstream(@TempDir Path tempDir) {
         Assumptions.assumeTrue(FileTools.isVivadoOnPath());