[XDP] Handle incorrect range of tiles usage for memory tiles settings #8657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinod Pangul <[email protected]>
stsoe
requested changes
Jan 13, 2025
Comment on lines
+388
to
+392
| try { | ||
| return static_cast<uint8_t>(std::stoi(input)); | ||
| } catch (const std::exception&) { | ||
| throw; | ||
| } |
There was a problem hiding this comment.
This change is a no-op. It has no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
[CR-1222763] Incorrect usage of range of memory tiles was resulting into segmentation faults.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
CR-1222763 - UG1076 has documentation error and needs an update for tile based settings of memory tiles.
How problem was solved, alternative solutions (if any) and why they were rejected
Parsing of user settings are in try-catch block. However, this was skipped as invalid string to int conversion was not thrown and re-caught.
Risks (if any) associated the changes in the commit
Low.
What has been tested and how, request additional testing if necessary
Verified on VEK280.
Verified that user now doesn't see crash and appropriate warning is emitted.
Verified that correct usage of memory tile settings are parsed correctly by plugin.
Documentation impact (if any)
Yes. UG1076 needs an update.