Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (ptq): Adding A2Q Upper Bound clipping to GPFQ #734

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Feat (ptq): Adding A2Q Upper Bound clipping to GPFQ #734

merged 2 commits into from
Dec 21, 2023

Conversation

fabianandresgrob
Copy link
Contributor

No description provided.

@fabianandresgrob fabianandresgrob force-pushed the gpfq/threshold branch 2 times, most recently from d086a15 to 62d2919 Compare November 15, 2023 12:10
volcacius
volcacius reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@volcacius volcacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unify implementation of get_upper_bound_on_l1_norm with the pre existing one under pre_scaling.py and make sure it jits correctly.

@Giuseppe5 Giuseppe5 self-requested a review November 17, 2023 13:34
@fabianandresgrob fabianandresgrob force-pushed the gpfq/threshold branch 2 times, most recently from 0bea4e3 to 3cfe53c Compare November 20, 2023 12:26
@fabianandresgrob fabianandresgrob force-pushed the gpfq/threshold branch 4 times, most recently from df07f6a to 9f4bde7 Compare December 1, 2023 17:39
@Giuseppe5 Giuseppe5 added the next release PRs which should be merged for the next release label Dec 20, 2023
@Giuseppe5 Giuseppe5 self-requested a review December 21, 2023 13:21
@Giuseppe5 Giuseppe5 requested review from Giuseppe5 and removed request for Giuseppe5 December 21, 2023 15:09
@Giuseppe5 Giuseppe5 requested review from Giuseppe5 and removed request for Giuseppe5 December 21, 2023 16:09
@Giuseppe5 Giuseppe5 merged commit 16d447a into Xilinx:dev Dec 21, 2023
347 checks passed
@fabianandresgrob fabianandresgrob deleted the gpfq/threshold branch January 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volcacius volcacius volcacius left review comments

@Giuseppe5 Giuseppe5 Awaiting requested review from Giuseppe5

Assignees
No one assigned
Labels
next release PRs which should be merged for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianandresgrob @volcacius @Giuseppe5