relocate fix for aie2p-none-unknown-elf arch #259
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves "Unknown AIE version in EFLAGS" error when test application is build for the triplet aie2p-none-unknown-elf target. For this target the EFLAGS is 3. fixes: Xilinx#258 Signed-off-by: Mika Laitio <[email protected]>
lamikr
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong and
stephenneuendorffer
as code owners
| @@ -370,6 +370,7 @@ void AIE::relocate(uint8_t *Loc, const Relocation &rel, uint64_t Val) const { | |||
| relocateAIE1(Loc, rel, Val); | |||
| break; | |||
| case 2: | |||
| case 3: | |||
There was a problem hiding this comment.
This looks dangerous. It is not guaranteed that relocations are the same between the two versions. Perhaps we are lucky though.
There was a problem hiding this comment.
We have a complete fix for this in a private repository. We will expedite merging that.
There was a problem hiding this comment.
Great to see external PRs coming in though. Thanks!
|
This PR is superseded by a canonical fix in #267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves "Unknown AIE version in EFLAGS"
error when test application is build for the
triplet aie2p-none-unknown-elf target.
For this target the EFLAGS is 3.
fixes: #258