Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIE] Legalize G_AND for <8 x s64> vector. #262

Open
wants to merge 2 commits into
base: aie-public
Choose a base branch
from
Open

[AIE] Legalize G_AND for <8 x s64> vector. #262

wants to merge 2 commits into from

Conversation

SagarMaheshwari99
Copy link
Collaborator

No description provided.

@SagarMaheshwari99 SagarMaheshwari99 changed the title [AIE2] Legalize G_AND for <8 x s64> vector. [AIE] Legalize G_AND for <8 x s64> vector. Jan 19, 2025
konstantinschwarz
konstantinschwarz reviewed Jan 19, 2025
View reviewed changes
llvm/lib/Target/AIE/aie2p/AIE2PLegalizerInfo.cpp Outdated
@@ -255,6 +255,13 @@ AIE2PLegalizerInfo::AIE2PLegalizerInfo(const AIE2PSubtarget &ST)
getActionDefinitionsBuilder({G_AND, G_OR})
.legalFor({S32})
.legalFor(AIE2PVectorTypes)
.bitcastIf(
[=](const LegalityQuery &Query) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this more generic and also handle 256/1024 bit vectors?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstantinschwarz konstantinschwarz konstantinschwarz left review comments

@abhinay-anubola abhinay-anubola Awaiting requested review from abhinay-anubola abhinay-anubola is a code owner

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@andcarminati andcarminati Awaiting requested review from andcarminati andcarminati is a code owner

@gbossu gbossu Awaiting requested review from gbossu gbossu is a code owner

@khallouh khallouh Awaiting requested review from khallouh khallouh is a code owner

@martien-de-jong martien-de-jong Awaiting requested review from martien-de-jong martien-de-jong is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@F-Stuckmann F-Stuckmann Awaiting requested review from F-Stuckmann F-Stuckmann is a code owner

@katerynamuts katerynamuts Awaiting requested review from katerynamuts katerynamuts is a code owner

@niwinanto niwinanto Awaiting requested review from niwinanto niwinanto is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagarMaheshwari99 @konstantinschwarz