Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel unit-tests from jgmelber's mlir-air fork. #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abisca
Copy link
Collaborator

@abisca abisca commented Mar 3, 2023

No description provided.

@abisca abisca requested review from jgmelber and fifield March 3, 2023 13:19
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not very useful or maintainable in their current form. They need to be turned into lit + FileCheck tests. If they are for testing MLIR passes then they need to be sorted into mlir/test. If they are end-to-end tests for running in system then they need host code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants