Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth=-1 mode to air-par-to-herd/segment/launch #866

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

erwei-xilinx
Copy link
Collaborator

… representing converting the innermost loop body into air.hierarchy op.

Assigning other negative values to depth means converting all loops; it would be ambiguous to assign depth=-2 as being the second innermost body, because that would be ambiguous.

@erwei-xilinx erwei-xilinx requested a review from fifield as a code owner January 20, 2025 17:48
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a useful shortcut vs. knowing the target's loop depth. The "any other negative" is the previous behavior? i.e. the option was initialized to -1 before

@erwei-xilinx
Copy link
Collaborator Author

This seems like a useful shortcut vs. knowing the target's loop depth. The "any other negative" is the previous behavior? i.e. the option was initialized to -1 before

Yes, in the previous version, any negative value means the same, i.e. converting all parallel ops. And that used to be the default behaviour.

@erwei-xilinx erwei-xilinx enabled auto-merge (squash) January 20, 2025 19:37
@erwei-xilinx erwei-xilinx merged commit 6e686c7 into Xilinx:main Jan 20, 2025
11 checks passed
@erwei-xilinx erwei-xilinx deleted the depth_m1_mode branch January 20, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants