Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused errors in build without assertions #872

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix unused errors in build without assertions #872

merged 1 commit into from
Jan 21, 2025

Conversation

jtuyls
Copy link
Contributor

@jtuyls jtuyls commented Jan 21, 2025

No description provided.

@jtuyls jtuyls force-pushed the fix-for-release-build branch from ab8bdfa to 9833367 Compare January 21, 2025 12:47
erwei-xilinx
erwei-xilinx approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@erwei-xilinx erwei-xilinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@erwei-xilinx erwei-xilinx merged commit d226668 into Xilinx:main Jan 21, 2025
11 checks passed
@jtuyls jtuyls deleted the fix-for-release-build branch January 21, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwei-xilinx erwei-xilinx erwei-xilinx approved these changes

@fifield fifield Awaiting requested review from fifield fifield is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtuyls @erwei-xilinx