Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRCanonicalize: Fixup dependency canonicalizer when air.wait_all was a source #882

Merged

Conversation

erwei-xilinx
Copy link
Collaborator

In memref read/write dependency tracing, air.wait_all should never be treated as a dependency source, because it doesn't touch memory itself. Dependency tracer should trace through air.wait_all to find the op which actually touched the memref.

@erwei-xilinx erwei-xilinx requested a review from fifield as a code owner January 24, 2025 23:02
@erwei-xilinx erwei-xilinx merged commit f742830 into Xilinx:main Jan 24, 2025
11 checks passed
@erwei-xilinx erwei-xilinx deleted the fixup_dep_cano_waitall_as_source branch January 24, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant