-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/YAF-66] 온보딩 생년월일 UI를 구현합니다. #22
Open
MoonsuKang
wants to merge
7
commits into
develop
Choose a base branch
from
ui/#19-onboarding-birthday
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+229
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongChyeon
reviewed
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2]
폰 해상도에 따라 양력/음력 글씨가 잘릴 가능성이 있기 때문에
horizontal Padding은 최소 20으로 두되 가운데 정렬하는 것도 좋을 거 같아요.
Box(
modifier = Modifier.fillMaxWidth(),
) {
Box(
modifier = Modifier
.fillMaxWidth()
.align(Alignment.Center)
.padding(horizontal = 20.dp)
.height(50.dp)
.background(OrbitTheme.colors.gray_700, shape = RoundedCornerShape(12.dp)),
)
Row(
modifier = Modifier
.fillMaxWidth()
.padding(20.dp),
horizontalArrangement = Arrangement.Center,
verticalAlignment = Alignment.CenterVertically,
) {
OrbitPickerItem(
state = lunarPickerState,
items = lunarItems,
visibleItemsCount = 3,
infiniteScroll = false,
modifier = Modifier.weight(1f),
textModifier = Modifier.padding(8.dp),
textStyle = OrbitTheme.typography.title2SemiBold,
itemSpacing = itemSpacing,
)
//...
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #19
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢
스크린에서 padding을 계산할 때 해당 값을
빼서
계산하셔야 됩니다~