[YS-70] feat: JWT 토큰에 사용자 권한(RoleType) 정보 포함 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
chock-cho
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
memberId가 아닌 member 파라미터 값을 조정하신 점이 좋았습니다 !
There was a problem hiding this comment.
네이밍 관련해서 MemberJpaRepository 와 MemberRepository 의 차이점에 대해 여쭈어봤는데, 구현하신 의도가 JPA와의 의존성에 대한 명시를 해주시겠다는 점을 말씀하셨습니다.
이에 통일성을 부여하기 위해서 MemberRpeository 로 컨벤션을 통일하기로 논의하였고, 이를 잘 반영해주신 것 같습니다 👍👍
Ji-soo708
added a commit
that referenced
this pull request
Jan 26, 2025
* refact: delete unused file * refact: add roleName to Enum * feat: add memberRole to jwt token * test: add role validation test code * test: move usecase's test code to application package * style: delete unused import * refact: refactor exception handling to be more granular for token validation * style: rename JpaMemberRepository to MemberRepository for better clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 작업 내용
✅ 셀프 체크리스트
🙋🏻 확인해주세요
🔗 Jira 티켓
https://yappsocks.atlassian.net/browse/YS-70