Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAG Engine Enhancements #244

Merged
merged 3 commits into from
Jan 2, 2025
Merged

RAG Engine Enhancements #244

merged 3 commits into from
Jan 2, 2025

Conversation

trheyi
Copy link
Contributor

@trheyi trheyi commented Jan 2, 2025

Changes

  • Refactored tests to use timestamp-based document IDs instead of UUIDs for better traceability
  • Added new methods to RAG engine:
    • HasIndex(): Check if an index exists
    • HasDocument(): Verify document existence
    • GetMetadata(): Retrieve document metadata
  • Enhanced test coverage for new functionality

trheyi added 3 commits January 2, 2025 17:55
…Ds. This change enhances the uniqueness of index names and document IDs by incorporating timestamps, improving test reliability and traceability. Additionally, update Qdrant engine to utilize a string-to-uint64 ID conversion for document indexing and retrieval, ensuring consistent ID handling across operations.
… integration tests. This update adds functionality to check for the existence of indexes and documents, improving the reliability of the RAG engine. Integration tests have been updated to validate these new methods, ensuring proper behavior before and after indexing operations.
This update introduces the GetMetadata method to the RAG engine, allowing retrieval of document metadata by its ID. The implementation includes error handling for non-existent documents and collections, as well as checks for nil context and closed engine states. Integration tests have been added to validate the GetMetadata functionality, ensuring it behaves correctly under various scenarios. This enhancement improves the metadata management capabilities of the RAG engine.
@trheyi trheyi merged commit bf635ed into YaoApp:main Jan 2, 2025
1 of 2 checks passed
Copy link

github-actions bot commented Jan 2, 2025

Thank you for the PR! The test workflow ( GO:1.23.0 DB:MySQL8.0 Redis:6 ) is running, the results of the run will be commented later.

Copy link

github-actions bot commented Jan 2, 2025

Thank you for the PR! The test workflow ( GO:1.23.0 DB:MySQL8.0 Redis:4 ) is running, the results of the run will be commented later.

Copy link

github-actions bot commented Jan 2, 2025

Thank you for the PR! The test workflow ( GO:1.23.0 DB:SQLite3 Redis:5 ) is running, the results of the run will be commented later.

Copy link

github-actions bot commented Jan 2, 2025

Thank you for the PR! The test workflow ( GO:1.23.0 DB:SQLite3 Redis:6 ) is running, the results of the run will be commented later.

Copy link

github-actions bot commented Jan 2, 2025

Thank you for the PR! The test workflow ( GO:1.23.0 DB:MySQL8.0 Redis:5 ) is running, the results of the run will be commented later.

Copy link

github-actions bot commented Jan 2, 2025

Thank you for the PR! The test workflow ( GO:1.23.0 DB:SQLite3 Redis:4 ) is running, the results of the run will be commented later.

Copy link

github-actions bot commented Jan 2, 2025

✨DONE✨ GO:1.23.0 DB:MySQL8.0 Redis:6 passed.

Copy link

github-actions bot commented Jan 2, 2025

✨DONE✨ GO:1.23.0 DB:SQLite3 Redis:6 passed.

Copy link

github-actions bot commented Jan 2, 2025

✨DONE✨ GO:1.23.0 DB:SQLite3 Redis:5 passed.

Copy link

github-actions bot commented Jan 2, 2025

✨DONE✨ GO:1.23.0 DB:MySQL8.0 Redis:4 passed.

Copy link

github-actions bot commented Jan 2, 2025

✨DONE✨ GO:1.23.0 DB:SQLite3 Redis:4 passed.

Copy link

github-actions bot commented Jan 2, 2025

✨DONE✨ GO:1.23.0 DB:MySQL8.0 Redis:5 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant