-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YarnSpinner-Godot 0.2.0 - Port some YarnSpinner-Unity 2.4.0 changes & integrate .yarnproject files #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
port pausable typewriter effect from YarnSpinner-Unity 2.4 add markup palette with custom inspector integrate some fields available in .yarnproject files with Godot YarnProject add importer for .yarnproject files
add pausing typewriter sample update godot version in continuous_build_check.yaml
…tres file in the project. the .yarnproject will appear as the C# YarnProject resource in the inspector.
dogboydog
force-pushed
the
port_2.4_changes
branch
from
November 26, 2023 17:17
6dbbde2
to
b04dafa
Compare
…g in godot 4.2 for editor interface. Use Utility.TagLines instead of AddTagsToLines
…n updates happening on .yarnproject import before string tables were available
dogboydog
force-pushed
the
port_2.4_changes
branch
from
December 2, 2023 02:40
9815ea5
to
7d156f3
Compare
dogboydog
force-pushed
the
port_2.4_changes
branch
from
December 2, 2023 19:29
5f5427e
to
78b7cbf
Compare
…sing to Yarn.System.Text.Json
dogboydog
force-pushed
the
port_2.4_changes
branch
from
December 4, 2023 15:03
db945bf
to
114db7d
Compare
…fixed with _ also mark DialogueRunner with [GlobalClass] for better editor integration
This was referenced Dec 8, 2023
Closed
port pausable typewriter effect from YarnSpinner-Unity 2.4 add markup palette with custom inspector integrate some fields available in .yarnproject files with Godot YarnProject add importer for .yarnproject files
add pausing typewriter sample update godot version in continuous_build_check.yaml
…tres file in the project. the .yarnproject will appear as the C# YarnProject resource in the inspector.
…g in godot 4.2 for editor interface. Use Utility.TagLines instead of AddTagsToLines
…n updates happening on .yarnproject import before string tables were available
…sing to Yarn.System.Text.Json
…fixed with _ also mark DialogueRunner with [GlobalClass] for better editor integration
…changes # Conflicts: # YarnSpinner-Godot.csproj
…consistent Export style. return to main menu from RoundedSample.tscn after dialogue complete
…remove some unused code
dogboydog
force-pushed
the
port_2.4_changes
branch
from
December 11, 2023 22:50
c288020
to
86f7fbb
Compare
…roject, but warn the user to create a .yarnproject file instead. Option.cs does not need to derive from GodotObject, so make it a plain class. update samples to 4.2.1-stable
dogboydog
force-pushed
the
port_2.4_changes
branch
from
December 22, 2023 16:24
70a7c85
to
be6b068
Compare
…h the Project > Tools menu
Merged
3 tasks
…or signals, and not capturing variables in the associated callables
dogboydog
force-pushed
the
port_2.4_changes
branch
from
February 2, 2024 02:52
4ef6edb
to
b7ab6f1
Compare
dogboydog
force-pushed
the
port_2.4_changes
branch
from
February 2, 2024 02:52
b7ab6f1
to
5c88715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
.yarnproject file integration
Fix #26
.yarnproject
files, which are JSON formatted files that define the settings used to work with your.yarn
scripts. The C# YarnProject custom resource for Godot is generated and updated automatically by the plugin. You can use the.yarnproject
file in the editor for drag-n-drop inspector functionality for YarnProjects. For example, you can drag your .yarnproject file into the Yarn Project slot on your DialogueRunner instances..godot
directory rather than in the main directories of your project. As such, it will no longer be version controlled in most cases as.godot
is typically ignored. However just opening your Godot project with this plugin enabled should re-generate the necessary files if you need to delete your.godot
folder for any reason or re-clone your project..tres
file this way, after you interact with the YarnProject, a.yarnproject
file should be created automatically alongside it. At that point, it's safe to delete the .tres file that you created, and carry on using the.yarnproject
file instead..yarnproject
integration. Changing fields like your source script patterns, localization CSV locations, or base language code will write to the.yarnproject
file, triggering recompilation of your yarn scripts..yarnproject
is read only. It doesn't seem this message can be removed, so please ignore it in this case and interact with the inspector as normal..yarnproject
file is saved. The inspector will show you a preview of which .yarn scripts would be included.sourcepatterns.mp4
.tres
formatted YarnProject file, such as localization CSV file locations. Then, delete your .tres YarnProject files and work with the.yarnproject
from then on.Pausing Typewriter effect
pausing.typewriter.mp4
The built-in Line View now can now identify markup based pauses and insert pauses into the typewriter effect.
Alice: wow this line now has a halt [pause=500 /] inside of it
onPauseStarted and onPauseEnded signals have been introduced on LineView.cs related to this effect
Effects.Typewriter now is a wrapper into the PausableTypewriter effect
Markup Palettes
markup_palette.mp4
* This is useful both as a standalone way to easily annotate your dialogue, but also as an example of the markup system.
* A custom inspector is provided with the plugin to simplify choosing colors for your markup tags.
Rounded Dialogue UI
addons/YarnSpinner-Godot/Scenes/RoundedDialogueSystem.tscn
.* A sample scene has been added to demonstrate this alternate look:
rounded.views.mp4
Other Changes
https://github.com/YarnSpinnerTool/YarnSpinner/releases/tag/v2.4.0
GetLineIDsForNodes
.YarnSpinner-Godot.props
. YarnSpinner.Compiler relies on System.Text.Json @ 7.0.2, so to avoid a warning when targeting net6.0, we're still delivering System.Text.Json and System.Text.Encodings.Web as dll files. This should reduce DLL version conflicts such as in Yarn imports a different System.Numerics assembly which causes ambiguity with the default System.Numerics. #20 - @CantyCanadian hopefully this completely clears up the issue you were seeing!DialogueRunner.SaveStateToPersistentStorage
andDialogueRunner.LoadStateFromPersistentStorage
to provide a simple method to save & load yarn variables to and from JSON in theuser://
directory.If you are updating an existing installation of this plugin, delete your
addons/YarnSpinner-Godot
directory before upgrading since some files have been removed in this update.There are a lot of changes in this one, so I'd like as much help testing as possible : ) Please let me know any bugs you discover or feedback you have when trying this update. I will see about porting some of the other samples from Unity in the future if I get a chance.