Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle socket exception in create_endpoint #39

Merged
merged 1 commit into from
May 30, 2017

Conversation

bplotnick
Copy link
Contributor

This fixes #37 by catching socket.gaierror (the exception for an unresolvable name) and defaults to 127.0.0.1.

I didn't add any logging for the error, but i think it might be nice. @kaisen, is there currently a preferred way to log warnings?

@coveralls
Copy link

coveralls commented May 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b739f35 on bplotnick:handle-socket-error into 2a6a6ef on Yelp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b739f35 on bplotnick:handle-socket-error into 2a6a6ef on Yelp:master.

@bplotnick bplotnick requested a review from kaisen May 30, 2017 02:24
@kaisen
Copy link
Member

kaisen commented May 30, 2017

:shipit:

@bplotnick
Copy link
Contributor Author

It looks like there's no real way to do the warning logging right now. I filed #40 to do that. This can be logged as a warning once that's done.

@kaisen kaisen merged commit 0bb8fbc into Yelp:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If your host can not be resolved by DNS, it will break tracing
3 participants