Upgrade auto_backup from v17 to v18 #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@Yenthe666, can you please review this? Thanks. |
Yenthe666
reviewed
Dec 12, 2024
auto_backup/models/db_backup.py
Outdated
|
|
||
| # Columns for local server configuration | ||
| host = fields.Char('Host', required=True, default='localhost') | ||
| port = fields.Char('Port', required=True, default=8069) | ||
| name = fields.Char('Database', required=True, help='Database you want to schedule backups for', | ||
| db_name = fields.Char('Database', required=True, help='Database you want to schedule backups for', |
There was a problem hiding this comment.
I'd rather not change field names for compatibility between versions honestly :)
There was a problem hiding this comment.
@Yenthe666 You're right, I change back the to the previous naming
|
Besides of the field name change it looks good to me :) I'd rather not change that because upgrading the app would mean data loss between any lower version and this one then. Most people aren't very experienced in this so I'd like to keep the field name the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.