Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
This PR resolves the issue below seen on my macOS Apple Silicon with a vanilla Yosys clone:
There are two issues:
boost
include path is incorrect ($(BREW_PREFIX)/boost/include/boost
instead of$(BREW_PREFIX)/boost/include
). This means that the canonical form of Boost includes such as#include <boost/...>
will not workboost-python3
library needs to be linked to detectboost-python3
properlyYou can work around these issues by manually setting the
BOOST_PYTHON_LIB
, but this PR makes it so that is not needed.Explain how this is achieved.
$(BREW_PREFIX)/boost/include
as the Boost include path-L$(BREW_PREFIX)/boost-python3/lib
to theLINKFLAGS
and includeLINKFLAGS
inCHECK_BOOST_PYTHON
If applicable, please suggest to reviewers how they can test the change.
This was tested on an Apple Silicon macOS (M2) with Pyosys enabled and was able to properly compile. I do not have access to an Intel macOS, it would be great if this can be tested against some builds as well.