fixed the review export not working - #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a file is created, but then the data is regenerated and used to send to the user. However this is broken as the $data variable in exportData only ever contains the last line of data. There is no need to generate it twice. this change removes the exportData function and just reads the contents of the already created csv. The export now works properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a file is created, but then the data is regenerated and used to send to the user. However this is broken as the $data
variable in exportData only ever contains the last line of data. There is no need to generate it twice.
this change removes the exportData function and just reads the contents of the already created csv. The export now works properly.