Merge pull request #10 from YousicianGit/feature/ObjectGraph

Print meaningful object graph for Unity components
YousicianGit · Jan 22, 2025 · 6cbc457 · 6cbc457
2 parents ea4413e + 671a4ed
commit 6cbc457
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/UnityProject/Assets/Plugins/Zenject/Source/Runtime/Injection/InjectContext.cs b/UnityProject/Assets/Plugins/Zenject/Source/Runtime/Injection/InjectContext.cs
@@ -268,6 +268,28 @@ public string GetObjectGraphString()
                 result.AppendLine(context.ObjectType.PrettyName());
             }
 
+#if !NOT_UNITY3D
+            if (this.ObjectInstance is UnityEngine.Component component)
+            {
+                // Print the GameObject hierarchy
+                var transform = component.transform;
+                while (transform != null)
+                {
+                    if (transform.name.EndsWith("(Clone)"))
+                    {
+                        // Stop printing when we find an instantiated object, we are validating that prefab
+                        result.AppendLine(transform.name.Replace("(Clone)", " (prefab)"));
+                        break;
+                    }
+                    else
+                    {
+                        result.AppendLine(transform.name);
+                        transform = transform.parent;
+                    }
+                }
+            }
+#endif
+
             return result.ToString();
         }
     }

diff --git a/...lugins/Zenject/Source/Runtime/Providers/SubContainerCreators/SubContainerCreatorCached.cs b/...lugins/Zenject/Source/Runtime/Providers/SubContainerCreators/SubContainerCreatorCached.cs
@@ -34,8 +34,10 @@ public DiContainer CreateSubContainer(List<TypeValuePair> args, InjectContext co
                 if (_subContainer == null)
                 {
 #if !ZEN_MULTITHREADING
-                    Assert.That(!_isLookingUp,
-                        "Found unresolvable circular dependency when looking up sub container!  Object graph:\n {0}", context.GetObjectGraphString());
+                    if (this._isLookingUp)
+                    {
+                        Assert.That(false, "Found unresolvable circular dependency when looking up sub container!  Object graph:\n {0}", context.GetObjectGraphString());
+                    }
                     _isLookingUp = true;
 #endif
 
@@ -48,7 +50,7 @@ public DiContainer CreateSubContainer(List<TypeValuePair> args, InjectContext co
 
                     Assert.IsNotNull(_subContainer);
                 }
-                else 
+                else
                 {
                     injectAction = null;
                 }