Allow decimal powers and improve rounding algorithm. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZCG-coder
added
T-Feature
- Using isdigit instead of isnumber.
- Introducing printers, a new way to format the output.
- root.cpp:83 Should be Fraction(number) instead.
- In rounding.cpp: Reworked rounding algorithm. - Added tests for power with a decimal exponent. - Added tests for root with a decimal index.
ZCG-coder
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Add support for decimal powers
For power expressions in the form of$n^{ \frac{a}{b} }$ , it can be simplified into
Also, the expression$\sqrt[\frac{a}{b}]{n}$ can be transformed into
With the
rootcomponent, it is possible to perform the above-mentioned operations. First, the number is converted into a fraction, and power/root operations are performed to obtain the result.2. Improve rounding algorithm
The
roundOff()method does not correctly round numbers. This PR introduces a new, reworked algorithm to allow rounding off to any desired precision.3. Introducing
printersThe old Unicode-based printing is not flexible enough to display nested operations. It is time to switch to a SymPy-like
printersystem.Tasks: