Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding credentials for basins on S3 #179

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

paulmueller
Copy link
Member

My laptop is broken so I am pushing this to a new branch so I can work with a temporary device.

paulmueller and others added 2 commits November 7, 2024 09:12
My laptop is broken so I am pushing this to a new branch so I can work with a temporary device.
@paulmueller paulmueller merged commit baa3f88 into master Nov 7, 2024
6 checks passed
@paulmueller paulmueller deleted the s3_integration branch November 7, 2024 13:00
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.38%. Comparing base (f021a48) to head (d2b8ce0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
shapeout2/gui/main.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   79.39%   79.38%   -0.02%     
==========================================
  Files          64       64              
  Lines        7062     7071       +9     
==========================================
+ Hits         5607     5613       +6     
- Misses       1455     1458       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant