Use upstream

[Adrian-Devries]

Currently, the project is not using current upstream sources; some resources are outdated, others are orphaned. Find details attached:

• MustangProjectResources.xlsx

Sometimes, resources from upstream have been renamed and/or modified. Find the modifications already made in your original repository attached:

• MustangProjectLibrary-notnormalized.patch
• MustangProjectValidator-notnormalized.patch

Note that the patches mentioned above do not ignore changes in white space. This way, it becomes obvious that the rule to keep the tab size has been ignored by the maintainers before.

This pull request removes orphaned resources and updates all resources to the most recent upstream. All resources from upstream are now located in folders reflecting the name of the distribution package. This way, it should be easier to maintain them. Documentation has been added to NOTICE.

With regards to visualization the upstream xrechnung-3.0.2-xrechnung-visualization-2024-06-20.zip has been extended as follows:

• A translation for fr-FR has been added:
  • fr.xml
• A decimal-format for fr-FR has been added to the following files:
  • xr-content.xsl
  • xrechnung-html.xsl

Note that I have filed a pull request against the upstream project as well (cf. itplr-kosit/xrechnung-visualization#23).

In addition, the Maven infrastructure has been normalized and modernized as in my previous pull request #623. The project is now using the most recent versions of all dependencies and plugins. Version information has been centralized in the top level POM. Two plugins have been added:

• org.openrewrite.maven:rewrite-maven-plugin (for normalizing Maven and Java sources)
• org.codehaus.mojo:xml-maven-plugin (for normalizing XML based resources)

The configuration of the plugin com.helger.maven:ph-schematron-maven-plugin has been changed to reflect the changes made in the resources tree. It is now not any longer necessary to rename sources from upstream and to modify them to reflect the renaming.

For the plugin org.codehaus.mojo:xml-maven-plugin a transformation script Normalize.xslt has been provided that not only normalizes white space etc., but also addresses certain issues, e.g., SXWN9009, SXWN9027 (find comments inside the file). This way, my previous pull request #621 is not needed anymore. Note that I have filed pull requests against upstream projects though (cf. #621 (comment)).

Currently, the plugin org.openrewrite.maven:rewrite-maven-plugin has been configured to do a dryRun only. Find an example of the output attached:

• rewrite.patch

Java sources have been changed accordingly where necessary to reflect the changes made in the resources tree. In addition, certain typos (e.g., "Arithmetric") and other quirks have been corrected. Without claiming to be complete:

• Main.java
  • performValidate: Parameter "String lang" added
• ClasspathResolverURIAdapter.java
  • Logger added (to enable debug messages)
• ClasspathResourceURIResolver.java
  • Class extracted from ZUGFeRDVisualizer (to enable usage from both classes ZUGFeRDVisualizer and ValidationLogVisualizer)
  • Certain constants moved to this class
  • Logger added (to enable debug messages)
  • Resolver modified (to reflect changes made in resources tree)
• ELanguage.java
  • Class extracted from ZUGFeRDVisualizer (to enable usage from both classes ZUGFeRDVisualizer and ValidationLogVisualizer)
• ValidationLogVisualizer.java
  • Using extracted classes (see above)
  • applyXSLTToPDF: Parameter "ELanguage lang" added, transformer parameter set (although the script result-pdf.xsl has not been localized yet)
  • toFOP: Parameter "ELanguage lang" added, signature with default value added
• ZUGFeRDVisualizer.java
  • visualize: Using upstream HTML transformation
  • applyXSLTToHTML: Parameter "ELanguage lang" added, transformer parameter set
  • applyXSLTToPDF: Parameter "ELanguage lang" added, transformer parameter set
  • toFOP: Parameter "ELanguage lang" added, signature with default value added
• EVersion.java
  • Class added
• SchemesPerVersion.java
  • Class added
• ScriptsPerVersion.java
  • Class added
• XMLValidator.java
  • Various changes to reflect the changes made in resources tree
  • Handling for all flavors of OrderX added
  • Handling for UBL CreditNote added
  • Handling for other flavors of XRechnung added

Of course, the new script result-pdf.xsl has been kept, but typos have been corrected there as well.

All tests succeed. Find log files attached:

• Mustang-CLI-2.15.3-SNAPSHOT-LogFiles.zip

By the way, generating the XSLT scripts from Schematron files with the plugin com.helger.maven:ph-schematron-maven-plugin takes approximately 2 minutes, not more (cf. A_06_generate-resources.log).

[Adrian-Devries]

Changes re-applied after release 2.16.0. All tests succeed. Find log files attached.
Mustang-CLI-2.16.1-SNAPSHOT-LogFiles.zip

[jstaerk]

Thanks for your work but I find it a bit difficult to review 688 files, can you break this up into several modular PRs?

[Adrian-Devries]

Thanks for your work but I find it a bit difficult to review 688 files, can you break this up into several modular PRs?

I am sorry, it seems that you did not get the idea. It is not possible to split this.