Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2022.10.04] feat/changeSingingListTitle >> 싱잉리스트 디테일 뷰 패딩값 조절 및 alert 기능 삭제 #109

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[2022.10.04] feat/changeSingingListTitle >> 싱잉리스트 디테일 뷰 패딩값 조절 및 alert 기능 삭제 #109

merged 1 commit into from
Oct 4, 2022

Conversation

junginyu
Copy link
Collaborator

@junginyu junginyu commented Oct 4, 2022

작업사항

  • 싱잉리스트 디테일 뷰 내 패딩값 조절했습니다
  • 편집 활성화 시 생기는 X버튼에서 alert 기능 삭제했습니다

이슈 번호

#89

특이사항 (optional)

  • X버튼 눌렀을 때 singinglisttitle이 수정 이전으로 돌아가야함
  • 싱잉리스트 디테일 뷰 내 노래목록 따로 뷰 생성
  • 리스트에서 노래 삭제시 전체 삭제가 아닌 리스트 내에서만 삭제되도록 구현

@junginyu junginyu self-assigned this Oct 4, 2022
@junginyu junginyu added the ✨ Feature 기능 추가 label Oct 4, 2022
Anti9uA
Anti9uA approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@Anti9uA Anti9uA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Eunbi-Cho
Eunbi-Cho approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨어요~

@junginyu junginyu merged commit da7f785 into develop Oct 4, 2022
@terry-koo terry-koo deleted the feat/changeSingingListTitle branch May 15, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anti9uA Anti9uA Anti9uA approved these changes

@Eunbi-Cho Eunbi-Cho Eunbi-Cho approved these changes

@terry-koo terry-koo Awaiting requested review from terry-koo terry-koo is a code owner

Assignees

@junginyu junginyu

Labels
✨ Feature 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junginyu @Anti9uA @Eunbi-Cho