-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/#171: Tag 컴포넌트 추가 및 적용 #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TableViewCell 네이밍 변경
…rvable로 값 자동 바인딩 구현
…extFieldTabeViewCell에 타입 바인딩
… 상속에서 독립적으로 UI 구성으로 리팩토링
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
Tag 컴포넌트 추가 및 적용
Key Changes 🔑
1. Tag 컴포넌트 설계
기본 Tag로 Tag 클래스 설계
하위 클래스로 PurpleTag, YellowTag 클래스 생성
configuration 통해 Tag 타입 지정 가능
위와 같이 세가지 상태 존재
disabled 상태로 인해 ViewTag에도 normal, select, deselect로 네이밍 및 리터럴 값 수정이뤄짐
2. 재치 등록 Tag 컴포넌트 적용
Tag컴포넌트와 더불어 CheckRegisterView에서 반복으로 사용되는 컴포넌트들 내부 클래스로 정리해서 리팩토링 진행함
(코드가 그래도 좀 깔끔해져서 뿌듯... ^^)
Related Issues ⛱
#171, #172