-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/#176: 재치 검색 iOS UI 적용 및 리팩토링 #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 프로퍼티 모두 private으로 접근 제어 지정
… 상태 변경시 ViewModel 통해서 API 호출 예정
… 프로토콜 채택으로 클래스 구현 > 나의 재치 셀 역할
…er 프로토콜 채택으로 클래스 구현 > 내가 찾는 재치 셀 역할
…구현되어야 하는 것만 override 또는 추가
…서 구현되어야 하는 것만 override 또는 추가
…Controller 네이밍 변경
…따른 tag select 여부 설정 메서드 추가
…추가 및 프로퍼티 옵저버 통한 UI 변경 설정
…티 추가 및 프로퍼티 옵저버 통한 UI 변경 설정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
재치 검색 iOS UI 적용 및 리팩토링
Key Changes 🔑
BaseViewController mainView bottom 기준 safeArea > superView로 변경.
Tag configuration height25, height31 케이스 추가 및 도메인 UI에 적용
CenterAlignCollectionViewFlowLayout 추가
SearchZatchByRegister 프로토콜 통한 내가 찾는 재치, 내가 등록한 재치 바텀시트 셀 클래스 구현
ZatchTableViewCell 하위 클래스로 ZatchExchangeTableViewCell, ZatchShareTableViewCell 구현
Related Issues ⛱
#176, #171