WIP: DKG demo #36
Merged
WIP: DKG demo #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalieesk
reviewed
Jun 27, 2023
natalieesk
reviewed
Jun 27, 2023
natalieesk
reviewed
Jun 27, 2023
natalieesk
reviewed
Jun 27, 2023
natalieesk
reviewed
Jun 27, 2023
natalieesk
reviewed
Jun 27, 2023
natalieesk
requested changes
Jun 27, 2023
dconnolly
reviewed
Jun 27, 2023
| @@ -0,0 +1,16 @@ | |||
| [package] | |||
| name = "dkg" | |||
There was a problem hiding this comment.
Any chance this would get published? Any better names perhaps?
There was a problem hiding this comment.
We could rename them to something like frost-project-demo or something like that. But this won't get published so I don't think it's necessary.
|
If you'd like feel free to merge this and I can work on tests in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a demo for the DKG.
It's a WIP because it's missing tests. They will be a bit complex but I'll give it a shot soon.
However I did some refactorings that may be useful for other demos:
impl std::io::Writeandwriteln!for printing. This allows using the format syntax, without callingformat!explicitly, allows removing the customLoggertrait, and should work for printing to terminal or to a string for testing.Box<dyn std::error::Error>for return types. This allows returning mostly any type of error, including FROST error or our own errors.eyreto return our own errors instead trying to find matching errors in the library.