Skip to content

Commit

Permalink
fix: fix typos (#9140)
Browse files Browse the repository at this point in the history
  • Loading branch information
rex4539 authored Jan 22, 2025
1 parent c30187a commit 05ab250
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions book/src/dev/rfcs/0006-contextual-difficulty.md
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ fn mean_target_difficulty(&self) -> ExpandedDifficulty { ... }
Since the `PoWLimit`s are `2^251 − 1` for Testnet, and `2^243 − 1` for Mainnet,
the sum of these difficulty thresholds will be less than or equal to
`(2^251 − 1)*17 = 2^255 + 2^251 - 17`. Therefore, this calculation can not
overflow a `u256` value. So the function is infalliable.
overflow a `u256` value. So the function is infallible.

In Zebra, contextual validation starts after Canopy activation, so we can assume
that the relevant chain contains at least 17 blocks. Therefore, the `PoWLimit`
Expand Down Expand Up @@ -499,7 +499,7 @@ that the relevant chain contains at least 28 blocks. Therefore:
* there is always an odd number of blocks in `MedianTime()`, so the median is
always the exact middle of the sequence.

Therefore, the function is infalliable.
Therefore, the function is infallible.

### Test network minimum difficulty calculation
[test-net-min-difficulty-calculation]: #test-net-min-difficulty-calculation
Expand Down Expand Up @@ -580,7 +580,7 @@ In Zcash, the Testnet minimum difficulty rule starts at block 299188, and in
Zebra, contextual validation starts after Canopy activation. So we can assume
that there is always a previous block.

Therefore, this function is infalliable.
Therefore, this function is infallible.

### Block difficulty threshold calculation
[block-difficulty-threshold-calculation]: #block-difficulty-threshold-calculation
Expand Down Expand Up @@ -647,7 +647,7 @@ Note that the multiplication by `ActualTimespanBounded` must happen after the
division by `AveragingWindowTimespan`. Performing the multiplication first
could overflow.

If implemented in this way, the function is infalliable.
If implemented in this way, the function is infallible.

`zcashd` truncates the `MeanTarget` after the mean calculation, and
after dividing by `AveragingWindowTimespan`. But as long as there is no overflow,
Expand Down
2 changes: 1 addition & 1 deletion zebra-chain/src/amount.rs
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ where
}
}

// TODO: add infalliable impls for NonNegative <-> NegativeOrZero,
// TODO: add infallible impls for NonNegative <-> NegativeOrZero,
// when Rust uses trait output types to disambiguate overlapping impls.
impl<C> std::ops::Neg for Amount<C>
where
Expand Down
4 changes: 2 additions & 2 deletions zebra-chain/src/amount/tests/vectors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,12 @@ fn deserialize_checks_bounds() -> Result<()> {
let mut big_bytes = Vec::new();
(&mut big_bytes)
.write_u64::<LittleEndian>(big)
.expect("unexpected serialization failure: vec should be infalliable");
.expect("unexpected serialization failure: vec should be infallible");

let mut neg_bytes = Vec::new();
(&mut neg_bytes)
.write_i64::<LittleEndian>(neg)
.expect("unexpected serialization failure: vec should be infalliable");
.expect("unexpected serialization failure: vec should be infallible");

Amount::<NonNegative>::zcash_deserialize(big_bytes.as_slice())
.expect_err("deserialization should reject too large values");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use crate::common::{
/// This ensures that a new template can be deserialized and sent to interrupt the
/// block proposal requests if the old template is no longer valid in edge-cases where
/// an old template becomes invalid right after it's returned. We've seen the getblocktemplate
/// respond within ~50ms of a request locallly, and this test is run on GCP compute instances
/// respond within ~50ms of a request locally, and this test is run on GCP compute instances
/// that should offer comparable latency in CI.
pub const EXTRA_LONGPOLL_WAIT_TIME: Duration = Duration::from_millis(150);

Expand Down

0 comments on commit 05ab250

Please sign in to comment.