fix(ci): In config tests, look for the config being successfully loaded by Zebra #7900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra's configuration loading tests are checking for the file name of the config in any log. But since the entrypoint script also logs the file name, the test can pass before Zebra starts to run:
https://github.com/ZcashFoundation/zebra/actions/runs/6734364310/job/18305634496#step:5:226
(The red highlight shows
grep
finding the success pattern, and then Docker gets stopped.)Instead, we should check for the log line that loads the config.
This bug doesn't have a ticket, but it blocks this release checklist item in ticket #7764:
PR Author Checklist
Check before marking the PR as ready for review:
Will the PR name make sense to users?This is an internal CI test coverage bug.Is the documentation up to date?No doc updates required.Not a significant change.
Complex Code or Requirements
We need to add some wildcards to the log line, to ignore terminal formatting characters.
Solution
Testing
Manually inspect the CI logs for Zebra running and logging the config line.
Review
This is possibly a release blocker (but only if config loading is actually broken).
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.