fix(net): Fix a potential hang caused by accessing the address book directly

[teor2345]

Motivation

The outbound connector accesses the address book directly, potentially blocking other connections or async tasks. Instead, we can send the failure to the channel.

Also there are some unnecessary services arguments in address book updates.

These fixes happened as part of #7787.

PR Author Checklist

Check before marking the PR as ready for review:

• Will the PR name make sense to users?
• Does the PR have a priority label?
• Have you added or updated tests? Hangs are extremely difficult to test for.
• Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Complex Code or Requirements

Sending to channels is much faster and cheaper than locking a mutex, which can be delayed for a long time under heavy load.

Solution

• Send failures to the address book update channel
• Fix a (possibly unreachable) panic with a zero channel size
• Remove unnecessary services arguments from some address book updates
• Update tests

Testing

Existing tests cover this code, but hangs are hard to test for.

Review

This is a low priority bug fix.

Reviewer Checklist

Check before approving the PR:

• Does the PR scope match the ticket?
• Are there enough tests to make sure it works? Do the tests cover the PR motivation?
• Are all the PR blockers dealt with?
  PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

[arya2]

This is really nice.