Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved 4 problems + Graphs #52

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Solved 4 problems + Graphs #52

wants to merge 5 commits into from

Conversation

FedorKatta
Copy link
Collaborator

Solved problems:

  • Triangle of sticks
  • Colored cube
  • Anton and watermelons
  • Paid musical service Graphs:
  • Implemented Graph
  • Made Add/Remove functions for vertexes and edges.

Solved problems:
- Triangle of sticks
- Colored cube
- Anton and watermelons
- Paid musical service
Graphs:
- Implemented Graph
- Made Add/Remove functions for vertexes and edges.
@FedorKatta FedorKatta requested a review from Zener085 October 21, 2023 08:44
@FedorKatta FedorKatta linked an issue Oct 21, 2023 that may be closed by this pull request
@FedorKatta FedorKatta self-assigned this Oct 21, 2023
Copy link
Contributor

@Zener085 Zener085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Четвертая задача не изменена, так и не проходит по времени некоторые тесты
Не понял, какой смысл сейчас загружать графы, если там пока ничего не сделано нового

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Использование векторов - кринге

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не проходит временное ограничение. Временная сложность большая

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так а где дз?

@FedorKatta FedorKatta requested a review from Zener085 October 21, 2023 11:51
Copy link
Contributor

@Zener085 Zener085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Метод поиска пути не работает. Часть ошибок я описал
Чтобы понять, что все работает, загрузи мой коммит и тестируй на нем.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут ведь ошибки есть. Не нужно возвращать вершины, их достаточно возвращать
MinDist должнен быть приватным методом, если не должно использоваться вне метода поиска пути
Почему _edges превратились в матрицу? Это список ребер, а не матрица
Часть я не разобрал, но я думаю, что и так будет норм

Zener085 and others added 3 commits October 23, 2023 13:34
Пример использования графа
Made a Graph algorythm which can find the shortest way between two objects.
- Fully made Dijkstra's algorithm
- Started making DFS algorithm
Copy link
Contributor

@Zener085 Zener085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В имплементации графа есть лишние предметы + не доделан метод remove_edge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убери лишние детали - dfs здесь не нужен, нужен только алгоритм дейкстры

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А еще remove_edge так и не доделан

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants