Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: macos oob support #14

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: macos oob support #14

merged 2 commits into from
Jan 16, 2025

Conversation

gabrik
Copy link
Contributor

@gabrik gabrik commented Jan 2, 2025

Adds support for macos out of the box.

@gabrik
fix: macos oob support
8d2a79b 
Signed-off-by: Gabriele Baldoni <[email protected]>
@imstevenpmwork
Copy link
Collaborator

imstevenpmwork commented Jan 2, 2025 •
edited
Loading

@gabrik If we fix the port used in macOS, we should edit this section of exe2: https://github.com/ZettaScaleLabs/roscon2024_workshop/blob/fix/macos-oob/exercises/ex-2.md#note---starting-another-container-on-the-same-host

@imstevenpmwork imstevenpmwork added bug Something isn't working documentation Improvements or additions to documentation labels Jan 2, 2025
@gabrik
Copy link
Contributor Author

gabrik commented Jan 2, 2025 •
edited
Loading

I did not change the ports, those are still the default ones used by zenoh.

Nevermind my brain is still on vacation, I'll update both the script and the text.

@gabrik
fix: using env variable for ports
5240a8a 
Signed-off-by: Gabriele Baldoni <[email protected]>
@gabrik
Copy link
Contributor Author

gabrik commented Jan 2, 2025

should be better now.

I'll still wait for someone else to test it before making the PR ready.

@gabrik gabrik marked this pull request as ready for review January 12, 2025 15:56
@gabrik gabrik requested a review from imstevenpmwork January 16, 2025 09:20
@imstevenpmwork imstevenpmwork merged commit 7d79412 into main Jan 16, 2025
@imstevenpmwork imstevenpmwork deleted the fix/macos-oob branch January 16, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imstevenpmwork imstevenpmwork imstevenpmwork approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrik @imstevenpmwork